-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the new API for defining remoting types #58
Conversation
CI builds are failing because npm installs wrong version of strong-remoting. They should start passing once strongloop/strong-remoting#343 is landed. |
I'm trying this PR with NPM link to your branch in strongloop/strong-remoting#343 and it gives me the following error:
Could you please run npm test locally to see if you get the same failure? |
Will do. Note that the error is thrown by code in Circular dependencies are not fun :( |
f1cf3ae
to
b82bd1a
Compare
b82bd1a
to
bce9971
Compare
A follow-up for strongloop/strong-remoting#343, which dropped
Dynamic
and related APIs.@gunjpan please review
cc @richardpringle
Requires strongloop/strong-remoting#343
Connect to strongloop-internal/scrum-loopback#974
Connect to strongloop-internal/scrum-loopback#885
TODO before merging