Skip to content

Commit

Permalink
Merge pull request #55 from strongloop/feature/loopback-3x
Browse files Browse the repository at this point in the history
[SEMVER-MAJOR] Update to juggler@3 and remoting@3
  • Loading branch information
bajtos authored Sep 1, 2016
2 parents 59090d8 + e047c56 commit 90cbf65
Show file tree
Hide file tree
Showing 5 changed files with 22 additions and 13 deletions.
18 changes: 10 additions & 8 deletions lib/relations.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
// This file is licensed under the MIT License.
// License text available at https://opensource.org/licenses/MIT

'use strict';

/*!
* Dependencies
*/
Expand Down Expand Up @@ -39,25 +41,25 @@ function RelationMixin() {
*
* ```js
* Book.create(function(err, book) {
*
*
* // Create a chapter instance ready to be saved in the data source.
* var chapter = book.chapters.build({name: 'Chapter 1'});
*
*
* // Save the new chapter
* chapter.save();
*
*
* // you can also call the Chapter.create method with the `chapters` property
* // which will build a chapter instance and save the it in the data source.
* book.chapters.create({name: 'Chapter 2'}, function(err, savedChapter) {
* // this callback is optional
* });
*
* // Query chapters for the book
*
* // Query chapters for the book
* book.chapters(function(err, chapters) {
* // all chapters with bookId = book.id
* // all chapters with bookId = book.id
* console.log(chapters);
* });
*
*
* book.chapters({where: {name: 'test'}, function(err, chapters) {
* // All chapters with bookId = book.id and name = 'test'
* console.log(chapters);
Expand Down Expand Up @@ -231,4 +233,4 @@ function defineRelationProperty(modelClass, def) {
return scope;
}
});
}
}
2 changes: 2 additions & 0 deletions lib/remote-connector.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
// This file is licensed under the MIT License.
// License text available at https://opensource.org/licenses/MIT

'use strict';

/**
* Dependencies.
*/
Expand Down
10 changes: 6 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
{
"name": "loopback-connector-remote",
"version": "2.0.0-alpha.1",
"pubishConfig": { "tag": "next" },
"pubishConfig": {
"tag": "next"
},
"description": "Remote REST API connector for Loopback",
"main": "index.js",
"keywords": [
Expand All @@ -27,8 +29,8 @@
},
"homepage": "http://loopback.io",
"dependencies": {
"loopback-datasource-juggler": "^2.8.0",
"strong-remoting": "^2.3.0"
"loopback-datasource-juggler": "^3.0.0-alpha.7",
"strong-remoting": "^3.0.0-alpha.5"
},
"devDependencies": {
"assert": "^1.1.2",
Expand All @@ -37,7 +39,7 @@
"grunt-cli": "^0.1.13",
"grunt-contrib-jshint": "~0.10.0",
"grunt-mocha-test": "^0.11.0",
"loopback": "^2.2.0",
"loopback": "^3.0.0-alpha.3",
"mocha": "~1.21.4",
"strong-task-emitter": "0.0.5"
},
Expand Down
4 changes: 3 additions & 1 deletion test/helper.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

'use strict';

var extend = require('util')._extend;
var loopback = require('loopback');
var remoteConnector = require('..');

Expand Down Expand Up @@ -48,8 +49,9 @@ function createRemoteDataSource(remoteApp) {
* app.
*/
function createModel(options) {
var modelOptions = extend({ forceId: false }, options.options);
var Model = loopback.PersistedModel.extend(options.parent, options.properties,
options.options);
modelOptions);
if (options.app) options.app.model(Model);
if (options.datasource) Model.attachTo(options.datasource);
return Model;
Expand Down
1 change: 1 addition & 0 deletions test/remote-connector.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ describe('RemoteConnector', function() {

it('should support aliases', function(done) {
var calledServerUpsert = false;
ctx.ServerModel.patchOrCreate =
ctx.ServerModel.upsert = function(id, cb) {
calledServerUpsert = true;
cb();
Expand Down

0 comments on commit 90cbf65

Please sign in to comment.