Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent accidental upgrades to swagger-ui v3+ #255

Merged
merged 1 commit into from
Feb 5, 2019

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Feb 4, 2019

To prevent accidental upgrades to a new (and very incompatible) version of swagger-ui, I am proposing to add an explicit version check that will abort the test suite when upgrade is detected.

$ npm t

> loopback-component-explorer@6.3.1 test /Users/bajtos/src/loopback/component-explorer
> mocha


Upgrading from swagger-ui@2 to a newer major version is difficult, see
https://github.com/strongloop/loopback-component-explorer/issues/254
If you are confident about this change and have manually verified API Explorer
functionality in the browser, including access-token based authentication,
then you can delete this check.

npm ERR! Test failed.  See above for more details.

See #250, #253 and and #254.

@bajtos bajtos self-assigned this Feb 4, 2019
@bajtos bajtos requested review from jannyHou and dhmlau February 4, 2019 12:23
test/explorer.test.js Outdated Show resolved Hide resolved
@bajtos bajtos force-pushed the prevent-upgrade-to-swagger-ui-3 branch 2 times, most recently from 8cb1c4b to c770df4 Compare February 5, 2019 07:14
@bajtos
Copy link
Member Author

bajtos commented Feb 5, 2019

Waiting for #257 to update eslint config to allow ES6 features.

@bajtos bajtos force-pushed the prevent-upgrade-to-swagger-ui-3 branch from c770df4 to 02cfb55 Compare February 5, 2019 09:07
@bajtos bajtos merged commit 79fbea1 into master Feb 5, 2019
@bajtos bajtos deleted the prevent-upgrade-to-swagger-ui-3 branch February 5, 2019 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants