Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LTS #78

Merged
merged 1 commit into from
Nov 26, 2018
Merged

LTS #78

merged 1 commit into from
Nov 26, 2018

Conversation

jannyHou
Copy link
Contributor

Description

Add LTS announcement.

Related issues

  • connect to <link_to_referenced_issue>

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style
    guide

README.md Outdated

## Module Long Term Support Policy
This module adopts the [
Module Long Term Support (LTS)](http://github.com/CloudNativeJS/ModuleLTS) policy,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when using the "view", the table doesn't look quite right.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhmlau This is the preview I saw:

screen shot 2018-11-16 at 3 12 39 pm

README.md Outdated
This module is in Active LTS mode, new features are no longer accepted.
(See [Module Long Term Support Policy](#module-long-term-support-policy) below.)

LoopBack 3 users looking for new features are encouraged to upgrade to LoopBack 4. Refer to [loopback-next#1849]((https://github.com/strongloop/loopback-next/issues/1849) for more information on how to upgrade.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra ( ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@jannyHou jannyHou force-pushed the lts branch 3 times, most recently from 588d9b1 to 4d3dff6 Compare November 16, 2018 20:18
README.md Outdated
| 5.x | Maintenance LTS | Sep 2017 | Dec 2019 |
| 4.x | Maintenance LTS | Dec 2016 | Apr 2019 |

Learn more about our LTS plan in [docs](https://loopback.io/doc/en/contrib/Long-term-support.html).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: in docs -> in the docs

Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening this patch to update README with the accurate LTS info 👍

When copying the Module Long Term Support table from other repositories, please make sure to update the major versions to match the actual versions of the target project!

README.md Outdated

| Version | Status | Published | EOL |
| ------- | --------------- | --------- | -------- |
| 6.x | Active LTS | Apr 2018 | Dec 2019 |
Copy link
Member

@bajtos bajtos Nov 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT, the latest (unpublished) version of loopback-cli is 5.x. Are there any plans to release 6.0 soon?

Please describe the following older releases as being in Maintenance LTS mode:

  • The first 4.x version was released in September 2017 (see d704a5a). It will reach EOL in Dec 2019.

  • The first 3.x release was released in July 2017 (see 4fcded7), 3.x will reach EOL in Apr 2019.

  • The first 2.x was released in March 2017 (see f685730), EOL will be Apr 2019.

  • The first 1.x was released in Januarry 2017 (see f72fea5), EOL will be Apr 2019.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bajtos 😨 good catch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope we haven't planned for 6.0 yet...

Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there!

One more comment to address, no further review is necessary as far as I am concerned & assuming you change 4.x EOL to Dec 2019 as proposed below.

README.md Outdated
| Version | Status | Published | EOL |
| ------- | --------------- | --------- | -------- |
| 5.x | Active LTS | Nov 2018 | Dec 2019 |
| 4.x | Maintenance LTS | Sep 2017 | Apr 2019 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Earlier this year (e.g. in May), if a developer wanted to pick the latest Node.js & loopback-cli versions for their projects, they would have used Node.js 8.x and loopback-cli@4. Thus we need to keep loopback-cli@4 supported as long as Node.js 8.x is supported (Dec 2019).

@jannyHou jannyHou force-pushed the lts branch 3 times, most recently from db6b43d to ca04818 Compare November 26, 2018 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants