-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hello-strongbox-maven #28
base: master
Are you sure you want to change the base?
Conversation
I got caught up in some work today, so i didnt get to finish implementing your suggestions. Will do it tomorrow. |
I fixed the outstanding issues. However i cannot seem to push a package right now (see https://www.rushworth.us/lisa/?p=6239 ) |
# This is seperate so it may only be deployed conditionally | ||
- name: Maven deploy |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually leave it as it is right now. It might be useful for branch deploys / testing.
Hmm... yeah that sounds like the issue @j4ckofalltrades and @carlspring mentioned. I guess the only way to fix it in the current moment would be to increment the versions for each project before merging a PR. |
Yes, unfortunately... (Unless, you'd like to raise a support ticket with Github each time you'd like to test it). |
It should be ready right now, shouldn't it? |
Hi, @BjoernAkAManf ! Thank you for your contribution! Would you mind signing the ICLA, as described in the Contributing page? Also, please, feel free to join our chat channel, if you'd like to learn more about the project and/or like to find out what else you could help with. Kind regards, Martin |
Done 😄 . I'll keep a look at the Chat(, as I desperately need to update my Tech Stack to a fully self hosted one 😛 ). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Great! I will not merge this yet, because there's another global problem with the deployment of these example artifacts (it's applicable for all the supported tools). Please, check my comment in the master task ( strongbox/strongbox#1927 ). |
@carlspring maybe we can approach the issue here the same way as @j4ckofalltrades suggested in his comment ? |
I agree. @BjoernAkAManf , could you please look into this? Thanks! 👍 |
I'll have a look this weekend :). unfortunately quite busy this week. |
So i added the workaround by @j4ckofalltrades which was not that hard, considering all the hard work already done 👍 |
See strongbox/strongbox#1927