Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: article extender question/answer models + service #615

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

bobaaaaa
Copy link
Contributor

What

  • added a new Body type ARTICLE_EXTENDER
  • BodyNode type is just a string -- using question for filtering
  • add new ArticleExtenderServer method/function to receive answers for a question
  • deprecated TRUST_BOX (already deleted in cms, adapter, frontend)

Example Body with initial questions

{
  "children": [
    {
      "children": [],
      "elements": [],
      "fields": {},
      "type": "question",
      "text": "Was hilft gegen Ungeziefer im Garten?",
      "reference": null
    },
  ],
  "type": "ARTICLE_EXTENDER"
}

Copy link

github-actions bot commented Dec 16, 2024

The latest Buf updates on your PR. Results from workflow proto / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedDec 17, 2024, 9:13 AM

maxfrauscher
maxfrauscher previously approved these changes Dec 16, 2024
Copy link

@maxfrauscher maxfrauscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ich finds sauber! 🚀

harryherbig
harryherbig previously approved these changes Dec 17, 2024
Copy link
Contributor

@harryherbig harryherbig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thisismana
thisismana previously approved these changes Dec 17, 2024
Copy link
Member

@thisismana thisismana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just left a few naming suggestions

stroeer/page/article/v1/article_extender_service.proto Outdated Show resolved Hide resolved
stroeer/page/article/v1/article_extender_service.proto Outdated Show resolved Hide resolved
@bobaaaaa bobaaaaa merged commit 5dbb4a3 into main Dec 17, 2024
13 checks passed
@bobaaaaa bobaaaaa deleted the feat/ae-questions branch December 17, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants