Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: push tapir to Buf schema registry for each new tag #553

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

moritzzimmer
Copy link
Member

@moritzzimmer moritzzimmer commented Jul 2, 2024

what

Push tapir on release to the (public) buf schema registry of tapir.

why

see https://buf.build/docs/bsr/introduction#bsr-goals for details

✅ automatic documentation, we could remove duplications for funcdoc and simplify tools, see https://buf.build/stroeer/tapir
✅ automatic generation of client SDKs for various proto/grpc versions and languages like java, TypeScript, Go, Swift and Python - we could remove our tooling around packaging and hosting SDKs

🟡 might be free (see plans), according to buf beta price it would cost $34.00/month for Teams plan which doesn't add much value
🟡 we would need to refactor our imports in the client projects to the buf naming conventions, see examples for java and go

@moritzzimmer moritzzimmer self-assigned this Jul 2, 2024
@moritzzimmer moritzzimmer mentioned this pull request Jul 2, 2024
@moritzzimmer moritzzimmer added 📖 documentation Improvements or additions to documentation 📔 RFC Request for comments java Pull requests that update Java code github_actions Pull requests that update Github_actions code go Pull requests that update Go code labels Jul 2, 2024
@moritzzimmer moritzzimmer merged commit 386517f into main Jul 5, 2024
10 checks passed
@moritzzimmer moritzzimmer deleted the feat/push_buf_bsr branch July 5, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation Improvements or additions to documentation github_actions Pull requests that update Github_actions code go Pull requests that update Go code java Pull requests that update Java code 📔 RFC Request for comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants