chore: update required npm and node version for node-proto #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-kleemann
requested review from
moritzzimmer,
harryherbig,
thisismana,
bobaaaaa,
saefty and
jadiedrich
as code owners
michael-kleemann
changed the title
bobaaaaa
approved these changes
Feb 12, 2024
|
@bobaaaaa thanks for merging. Could you also create a release to make it usable? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
set a required minimum npm version for node-proto instead of fixed version 9.
Node 18 LTS now ships with npm 10.
I assume it is unlikely that new node/npm versions will break functionality.
outcome
When updating node/npm the package won't fail to install.
Right now it blocks our pipeline to build our application.