Skip to content

Commit

Permalink
Merge pull request #363 from stripe/aditya-remove-veneurlocalonly
Browse files Browse the repository at this point in the history
Remove veneurlocalonly tag from Veneur's internal metrics
  • Loading branch information
cory-stripe authored Jan 27, 2018
2 parents 1c765a1 + 02a414a commit 75fd6fa
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
** Datadog, Kafka, MetricExtraction, and SignalFx sinks now emits `sink.metrics_flushed_total` for metric flush counts and tag it with `sink`
** Datadog and LightStep sinks now emit `veneur.sink.span_flush_total_duration_ns` for span flush duration and tag it with `sink`
** Datadog, Kafka, MetricExtraction, and LightStep sinks now emit `sink.spans_flushed_total` for metric flush counts and tag it with `sink`
* Veneur's internal metrics are no longer tagged with `veneurlocalonly`. This means that percentile metrics (such as timers) will now be aggregated globally.


## Added
* `veneur-emit` now infers parent and trace IDs from the environment (using the variables `VENEUR_EMIT_TRACE_ID` and `VENEUR_EMIT_PARENT_SPAN_ID`) and sets these environment variables from its `-trace_id` and `parent_span_id` when timing commands, allowing for convenient construction of trace trees if traced programs call `veneur-emit` themselves. Thanks, [antifuchs](https://github.com/antifuchs)
Expand Down
1 change: 0 additions & 1 deletion server.go
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,6 @@ func NewFromConfig(logger *logrus.Logger, conf Config) (*Server, error) {
return ret, err
}
ret.Statsd.Namespace = "veneur."
ret.Statsd.Tags = append(ret.Tags, "veneurlocalonly")

// nil is a valid sentry client that noops all methods, if there is no DSN
// we can just leave it as nil
Expand Down

0 comments on commit 75fd6fa

Please sign in to comment.