Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dev-app location page not scrollable issue #829

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

tim-lin-bbpos
Copy link
Collaborator

Summary

Fix dev-app location page not scrollable issue

Motivation

https://jira.corp.stripe.com/browse/TERMINAL-40665
The FlatList seems has issue on Android emulator, change to ScrollView with List structure and combine two scrollable View into one.

Testing

  • I tested this manually
  • I added automated tests

Documentation

Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

@nazli-stripe nazli-stripe merged commit cbe7199 into main Oct 3, 2024
3 checks passed
@nazli-stripe nazli-stripe deleted the bbpos/location-scroll branch October 3, 2024 18:19
@tim-lin-bbpos tim-lin-bbpos mentioned this pull request Oct 7, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants