Integrate ios local mobile terms of service accept callback #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-lin-bbpos
requested review from
billfinn-stripe,
bric-stripe,
nazli-stripe,
ugochukwu-stripe,
ebarrenechea-stripe and
mshafrir-stripe
as code owners
tim-lin-bbpos
changed the title
tim-lin-bbpos
changed the title
gliu-stripe
approved these changes
Aug 8, 2024
| @@ -94,6 +94,9 @@ export default function DiscoverReadersScreen() { | |||
| onDidReportAvailableUpdate: (update) => { | |||
| Alert.alert('New update is available', update.deviceSoftwareVersion); | |||
| }, | |||
| onDidAcceptTermsOfService: () => { | |||
| Alert.alert('Accept terms of Service'); | |||
There was a problem hiding this comment.
nit: Should this be "Accepted Terms of Service"?
not too important since it's just the dev app, but just fyi that this callback fires after acceptance
nazli-stripe
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add callback event when user accept the terms of service of using tap to play on iOS side.
Motivation
Part of the request from https://bugs.bbpos.com/projects/SDK/issues/SDK-189
iOS ref: https://stripe.dev/stripe-terminal-ios/docs/Protocols/SCPLocalMobileReaderDelegate.html#/c:objc(pl)SCPLocalMobileReaderDelegate(im)localMobileReaderDidAcceptTermsOfService:
Testing
Documentation
Select one: