Populate pi in error #707
Merged
Populate pi in error #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianlin-bbpos
requested review from
billfinn-stripe,
bric-stripe,
nazli-stripe,
ugochukwu-stripe,
ebarrenechea-stripe and
mshafrir-stripe
as code owners
nazli-stripe
requested changes
May 23, 2024
src/types/index.ts
Outdated
| @@ -88,6 +88,7 @@ export type LocationStatus = 'notSet' | 'set' | 'unknown'; | |||
| export type StripeError<T = CommonError> = { | |||
| code: T; | |||
| message: string; | |||
| paymentIntent?: PaymentIntent.Type; | |||
There was a problem hiding this comment.
it might be better to modify the PaymentIntentResultType and add a third option that has both error and PI populated
nazli-stripe
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Populate PaymentIntent when there is an error after calling collectPaymentMethod/confirmPaymentIntent
Motivation
It would be useful to know which state the payment intent is in after the error has occurred.
Testing
Documentation
Select one: