Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reader settings #630

Merged
merged 7 commits into from
Mar 7, 2024
Merged

Support reader settings #630

merged 7 commits into from
Mar 7, 2024

Conversation

ianlin-bbpos
Copy link
Collaborator

Summary

Support reader settings

Motivation

Support setting & getting reader settings in the RN SDK.

Testing

  • I tested this manually
  • I added automated tests

Documentation

Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

@maxa-stripe
Copy link
Contributor

@ianlin-bbpos Thanks for the very quick turnaround on this! I got to playing with the dev app, and it looks & works great on Android. However, on iOS I observed the following behavior:

  • When text to speech speakers is already enabled on a reader, loading its settings doesn't show the toggle in its "on" condition.
  • When I attempt to enable text to speech speakers on a connected reader, I see the following error:
    Screenshot 2024-03-06 at 11 19 04

I'm not well versed in React Native, so it's possible that I've missed some required setup step. Does this seem familiar at all?

@ianlin-bbpos
Copy link
Collaborator Author

@maxa-stripe Sorry, this is actually my mistake that should not be put, I forgot to do code debugging on the IOS side before create this PR. Let me commit new code modificatione, thanks for your review.

@nazli-stripe nazli-stripe merged commit 2157844 into main Mar 7, 2024
2 checks passed
@nazli-stripe nazli-stripe deleted the bbpos/support-reader-settings branch September 7, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants