Fix detox issue #618
Merged
Fix detox issue #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eact-native into fix-detox-issue merge code
nazli-stripe
requested review from
billfinn-stripe,
bric-stripe and
chr-stripe
as code owners
bric-stripe
approved these changes
Jan 31, 2024
Comment on lines
+178
to
+180
| setTimeout(() => { | ||
| handlePermissions(); | ||
| }, 1000); // delay of 1 second |
There was a problem hiding this comment.
not new for this PR so no need to block on it but why do we need this in the app layer? Won't the native SDK request and prompt for the permissions when needed? 🤔
There was a problem hiding this comment.
The native Android SDK doesn't prompt for permissions itself, it requires the integration to do so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CI has been blocked for a bit due to failing e2e Android tests. We upgraded Detox to ensure our dependencies are officially supported, and discovered an issue with the Permissions API being called too early:
Error: Tried to use permissions API while not attached to an Activity.Not the prettiest option but adding a 1 second delay before calling the permission checker fixes the issue, and since this is for the example application running on the emulator that seemed good enough to unblock new PRs
Motivation
Unblock CI
Testing
CI
Documentation
Select one: