AoD support #578
Merged
AoD support #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazli-stripe
commented
Dec 1, 2023
Comment on lines
76
to
108
| public void onActivityCreated(@NonNull final Activity activity, @Nullable final Bundle savedInstanceState) { | ||
| Log.d("onActivityCreated", activity.toString()); | ||
| } | ||
|
|
||
| @Override | ||
| public void onActivityStarted(@NonNull final Activity activity) { | ||
| Log.d("onActivityStarted", activity.toString()); | ||
| } | ||
|
|
||
| @Override | ||
| public void onActivityResumed(@NonNull final Activity activity) { | ||
| Log.d("onActivityResumed", activity.toString()); | ||
| } | ||
|
|
||
| @Override | ||
| public void onActivityPaused(@NonNull final Activity activity) { | ||
| Log.d("onActivityPaused", activity.toString()); | ||
| } | ||
|
|
||
| @Override | ||
| public void onActivityStopped(@NonNull final Activity activity) { | ||
| Log.d("onActivityStopped", activity.toString()); | ||
| } | ||
|
|
||
| @Override | ||
| public void onActivitySaveInstanceState(@NonNull final Activity activity, @NonNull final Bundle outState) { | ||
| Log.d("onActivitySaveInstanceState", activity.toString()); | ||
| } | ||
|
|
||
| @Override | ||
| public void onActivityDestroyed(@NonNull final Activity activity) { | ||
| Log.d("onActivityDestroyed", activity.toString()); | ||
| } |
There was a problem hiding this comment.
log activities for debugging
nazli-stripe
commented
Dec 1, 2023
| @@ -54,11 +62,48 @@ public ReactNativeHost getReactNativeHost() { | |||
| @Override | |||
| public void onCreate() { | |||
| super.onCreate(); | |||
| registerActivityLifecycleCallbacks(this); | |||
| TerminalApplicationDelegate.onCreate(this); | |||
There was a problem hiding this comment.
call onCreate asap when the app is launched
nazli-stripe
force-pushed
the
nazli/aod
branch
from
1567a3c to
95a3bab
Compare
nazli-stripe
requested review from
billfinn-stripe,
bric-stripe and
chr-stripe
as code owners
bric-stripe
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds AoD support for RN SDK. Users will need to modify their
MainApplication.javafile to callonCreate, other options we tested didn't register the callbacks fast enough on S700.Motivation
Feature parity!
Testing
Documentation
Select one: