Upgrade to RN 0.72 #572
Merged
Upgrade to RN 0.72 #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazli-stripe
force-pushed
the
nazli/rn-update
branch
from
6c9c14c to
02fa5f2
Compare
nazli-stripe
force-pushed
the
nazli/rn-update
branch
from
06fc9af to
50290aa
Compare
nazli-stripe
force-pushed
the
nazli/rn-update
branch
from
67f8526 to
e0f4bbd
Compare
chr-stripe
reviewed
Nov 21, 2023
chr-stripe
reviewed
Nov 21, 2023
Co-authored-by: chr-stripe <[email protected]>
Co-authored-by: chr-stripe <[email protected]>
nazli-stripe
force-pushed
the
nazli/rn-update
branch
from
9cae835 to
b6d0ce0
Compare
nazli-stripe
requested review from
billfinn-stripe and
bric-stripe
as code owners
nazli-stripe
force-pushed
the
nazli/rn-update
branch
from
97913ca to
f4d93a6
Compare
chr-stripe
reviewed
Nov 24, 2023
Comment on lines
+119
to
+120
| // The version of react-native is set by the React Native Gradle Plugin | ||
| implementation("com.facebook.react:react-android") |
dev-app/android/app/src/main/java/com/dev/app/stripeterminalreactnative/MainApplication.java
Show resolved
Hide resolved
Comment on lines
1
to
6
| /** | ||
| * Copyright (c) Meta Platforms, Inc. and affiliates. | ||
| * | ||
| * <p>This source code is licensed under the MIT license found in the LICENSE file in the root | ||
| * directory of this source tree. | ||
| */ |
There was a problem hiding this comment.
Should probably remove this, I think
nazli-stripe
commented
Nov 27, 2023
dev-app/android/app/src/main/java/com/dev/app/stripeterminalreactnative/MainApplication.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades RN version used in the project to latest 0.71 and Android Gradle Plugin to 8.1.1. These changes allowed us the necessary setup to bump the native SDKs to 3.2.0, which are also done in this PR.
Motivation
SDK update
Testing
Documentation
Select one: