Fix not specifying autoReconnectOnUnexpectedDisconnect issue. #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricLin-BBpos
requested review from
billfinn-stripe,
bric-stripe,
nazli-stripe,
rv-stripe and
chr-stripe
as code owners
Comment on lines
227
to
229
| params.getBoolean("autoReconnectOnUnexpectedDisconnect") ?: false | ||
| if (params.hasKey("autoReconnectOnUnexpectedDisconnect")) { | ||
| params.getBoolean("autoReconnectOnUnexpectedDisconnect") | ||
| } else false |
There was a problem hiding this comment.
there is an existing getBoolean mapper to deal with this, can we use that?
nazli-stripe
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #532
Fix issue that Calling connectBlueToothReader without autoReconnectOnUnexpectedDisconnect will case execption.
Motivation
Fix #532
Testing
Documentation
Select one: