Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: github actions #967

Merged
merged 10 commits into from
Mar 10, 2021
Merged

CI: github actions #967

merged 10 commits into from
Mar 10, 2021

Conversation

richardm-stripe
Copy link
Contributor

@richardm-stripe richardm-stripe commented Mar 10, 2021 •
edited
Loading

r? @ob-stripe this is the last library!

  • Adds a github actions ci workflow.
    • Removes coveralls.
    • bundle exec rubocop runs in Ruby 2.7.
    • bundle exec test runs in all supported ruby versions.
      • And a slightly newer version of JRuby than travis runs.

@richardm-stripe richardm-stripe changed the title [WIP] CI: github actions CI: github actions Mar 10, 2021
ob-stripe
ob-stripe reviewed Mar 10, 2021
View reviewed changes
Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We should start testing Ruby 3.0 though.

@richardm-stripe richardm-stripe merged commit f864e68 into master Mar 10, 2021
@richardm-stripe richardm-stripe deleted the richardm-gha branch March 10, 2021 19:48
@stripe stripe deleted a comment from travisbarronsanabria Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ob-stripe ob-stripe ob-stripe left review comments

Assignees

@ob-stripe ob-stripe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richardm-stripe @ob-stripe