Rename API resource's request
method
#936
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen in #928, the
refresh
method doesn't work for an event class.This is because event has a field called
request
, and it ends upreplacing the
request
method that it inherited from being an APIresource, so when
refresh
tries to make a request, it fails because ittries to invoke it on the accessor added for the event's property.
Here we give
request
a much more unique name so that it will neverconflict with a property field again, and update all internal references
to use the new name. We use
alias
to make the old name available forbackwards compatibility reasons because its been around for so long that
people are probably calling it.
Fixes #928.
r? @ob-stripe @richardm-stripe