Upgrade Rubocop to 0.79 #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically went through trying to make the whole stripe-ruby test run Ruby 2.7 friendly. @dennisvdvliet got most of the internal stuff, but we still have a couple external dependencies that are producing warning. Here we upgrade Rubocop to 0.79, which curbs some warnings. A few lints were moved and/or renamed, so I've modified the `.rubocop.yml` appropriately, but there's no major changes there. The last broken dependency is Webmock, and luckily I think it's pretty easy to fix, so I'll send them a PR and see what happens.
|
Thanks OB. And opened one more PR to Webmock over here: bblimke/webmock#871 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically went through trying to make the whole stripe-ruby test run
Ruby 2.7 friendly. @dennisvdvliet got most of the internal stuff, but we
still have a couple external dependencies that are producing warnings.
Here we upgrade Rubocop to 0.79, which curbs some warnings. A few lints
were moved and/or renamed, so I've modified the
.rubocop.ymlappropriately, but there's no major changes there.
The last broken dependency is Webmock, and luckily I think it's pretty
easy to fix, so I'll send them a PR and see what happens.
r? @ob-stripe
cc @stripe/api-libraries