Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak retry logic to be a little more like stripe-node #828

Merged
merged 1 commit into from
Aug 16, 2019

Commits on Aug 16, 2019

  1. Tweak retry logic to be a little more like stripe-node

    Tweaks the retry logic to be a little more like stripe-node's. In
    particular, we also retry under these conditions:
    
    * If we receive a 500 on a non-`POST` request.
    * If we receive a 503.
    
    I made it slightly different from stripe-node which checks for a 500
    with `>= 500`. I don't really like that -- if we want to retry specific
    status codes we should be explicit about it.
    
    We're actively re-examining ways on how to make it easier for clients to
    figure out when to retry right now, but I figure V5 is a good time to
    tweak this because the modifications change the method signature of
    `should_retry?` slightly, and it's technically a public method.
    brandur committed Aug 16, 2019
    Configuration menu
    Copy the full SHA
    b13add6 View commit details
    Browse the repository at this point in the history