Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[codegen] Remove SubscriptionScheduleRevision #824

Merged
merged 3 commits into from
Aug 9, 2019

Conversation

rattrayalex-stripe
Copy link
Contributor

r? @ob-stripe
cc @stripe/api-libraries @remi-stripe

Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If you want to do the release, make sure to include this note or something similar:
"Note that this is technically a breaking change, however we've chosen to release it as a minor version in light of the fact that this resource and its API methods were virtually unused."

@rattrayalex-stripe
Copy link
Contributor Author

Hmm, strange rubocop errors, don't think I got those locally... will debug...

@stripe-ci stripe-ci removed the approved label Aug 9, 2019
@rattrayalex-stripe rattrayalex-stripe merged commit 1272a3f into master Aug 9, 2019
@rattrayalex-stripe rattrayalex-stripe deleted the rattrayalex/codegen-c806fa1 branch August 9, 2019 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants