Static methods for delete #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ob-stripe Yep, this approach looks good to me. After it's fully built and merged, we should definitely try and provide some kind of guide (probably in the README) that describes the difference call styles that are available (static versus non-static). I think having the different methods with slightly different parameters is going to make usage somewhat non-obvious to new users. ptal @ob-stripe |
|
Added a commit to remove extra capture method and add tests for all deletes |
remi-stripe
changed the title
remi-stripe
changed the title
remi-stripe
force-pushed
the
ob-static-methods
branch
from
2d751b1
to
35fe2cd
Compare
|
Released as 4.12.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe @remi-stripe
Opening this PR for early feedback.
Things are much easier/less hacky than Python here since Ruby supports class methods and instance methods with same names.
We'll probably need to do some refactoring around the helper URL methods for non-CRUDL methods though.