Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FaradayStripeEncoder to encode all parameter styles #741

Merged
merged 1 commit into from
Feb 3, 2019

Commits on Feb 3, 2019

  1. Use FaradayStripeEncoder to encode all parameter styles

    Makes a few tweaks to hopefully simplify clarity things:
    
    * `FaradayStripeEncoder` now becomes the way to encode all of form,
      multipart form, and query parameters.
    * Introduce a cache in it so that we don't have to encode everything
      twice (once for logging, and once for the request body).
    * Try to sanitize logging a bit by replacing `Faraday::UploadIO`s found
      in incoming parameters with a string representation of the file (note
      that all other styles of file input like `File` or `Tempfile` have
      been converted to `Faraday::UploadIO` by the time they reach the
      encoder).
    brandur committed Feb 3, 2019
    Configuration menu
    Copy the full SHA
    9dd5bdb View commit details
    Browse the repository at this point in the history