Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for 'partner_id' in 'set_app_info' #658

Merged
merged 2 commits into from
Jun 28, 2018

Conversation

zachwick
Copy link
Contributor

This adds support for an optional partner_id attribute in the SetAppInfo hash.

@zwick-stripe zwick-stripe force-pushed the zwick_set_app_info_partner_updates branch 2 times, most recently from c603689 to bc3b40a Compare June 28, 2018 01:31
@ob-stripe
Copy link
Contributor

Looks like you have some linting errors. You'll want to fix the style errors and run bundle exec rubocop --auto-gen-config to regenerate the metrics limits.

ptal @zwick-stripe

@zwick-stripe zwick-stripe force-pushed the zwick_set_app_info_partner_updates branch from bc3b40a to 15029ff Compare June 28, 2018 15:03
@brandur-stripe
Copy link
Contributor

LGTM.

@brandur-stripe brandur-stripe merged commit ab3949b into master Jun 28, 2018
@brandur-stripe brandur-stripe deleted the zwick_set_app_info_partner_updates branch June 28, 2018 15:56
@brandur-stripe
Copy link
Contributor

Released as 3.17.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants