Add support for setting a logger #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandur-stripe
force-pushed
the
brandur-support-logger
branch
from
31fd4ef
to
18ca225
Compare
|
I suppose I should support error output as well ... |
Adds support for setting `Stripe.logger` to a logger that's compatible with `Logger` from Ruby's standard library. In set, the library will no longer log to stdout, and instead emit straight to the logger and defer decision on what log level to print to it. Addresses a request in #566.
brandur-stripe
force-pushed
the
brandur-support-logger
branch
from
18ca225
to
cb111a8
Compare
A few changes: * Add a new `Util.log_error` method which will forward to the equivalent of `#error` on a logger. * Move errors produced by `StripeClient` to use `Util.log_error`. * Change standard stdout logging behavior to log to stderr in the case of `Util.log_error. * Change `Stripe.log_level` values to be an enum in a similar fashion as the standard library's built in `Logger`.
|
Alright, I added support for printing errors to the logger's |
|
r? @deontologician-stripe Mind taking a look at this? |
|
LGTM |
|
Thanks Josh! |
|
Released as 3.3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for setting
Stripe.loggerto a logger that's compatiblewith
Loggerfrom Ruby's standard library. In set, the library will nolonger log to stdout, and instead emit straight to the logger and defer
decision on what log level to print to it.
Addresses a request in #566.