Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass params to transfer reversal #1399

Merged
merged 3 commits into from
May 8, 2024

Conversation

prathmesh-stripe
Copy link
Contributor

@prathmesh-stripe prathmesh-stripe commented May 8, 2024

Related: #1393

Changelog

  • Allow Stripe::Transfer.retrieve_reversal() to accept a params hash as the third argument, followed by opts. No changes to existing calls are necessary, but in a future major version this method will be updated to only accept params as the first argument.

@prathmesh-stripe prathmesh-stripe self-assigned this May 8, 2024
@prathmesh-stripe prathmesh-stripe force-pushed the prathmesh_fix_transfer_reversal branch from 4bebdd3 to 5262f81 Compare May 8, 2024 19:26
@prathmesh-stripe prathmesh-stripe force-pushed the prathmesh_fix_transfer_reversal branch from 5262f81 to 9cc328f Compare May 8, 2024 20:34
Copy link
Contributor

@helenye-stripe helenye-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accept a params hash as the first argument

I think this should be the third argument?

Also would you mind also adding a generic test to

context ".nested_resource_class_methods" do
?

Copy link
Contributor

@helenye-stripe helenye-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this!

test/stripe/api_operations_test.rb Outdated Show resolved Hide resolved
@prathmesh-stripe prathmesh-stripe force-pushed the prathmesh_fix_transfer_reversal branch from 6a9f593 to 10be4e3 Compare May 8, 2024 21:39
@prathmesh-stripe prathmesh-stripe merged commit 7f2bdfa into master May 8, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants