Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused partial param from initialize_from #1171

Merged
merged 1 commit into from
Jan 23, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/stripe/stripe_object.rb
Original file line number Diff line number Diff line change
Expand Up @@ -429,13 +429,13 @@ class << self; self; end
# * +:opts:+ Options for StripeObject like an API key.
# * +:partial:+ Indicates that the re-initialization should not attempt to
# remove accessors.
protected def initialize_from(values, opts, partial = false)
protected def initialize_from(values, opts)
@opts = Util.normalize_opts(opts)

# the `#send` is here so that we can keep this method private
@original_values = self.class.send(:deep_copy, values)

removed = partial ? Set.new : Set.new(@values.keys - values.keys)
removed = Set.new(@values.keys - values.keys)
added = Set.new(values.keys - @values.keys)

# Wipe old state before setting new. This is useful for e.g. updating a
Expand Down