Fix APIResource#retrieve bug not returning instance of custom resourc…

…es (#1476) * Fix refresh bug not returning specific instance type for custom resources * tests
stripe · Oct 28, 2024 · fb11d83 · fb11d83
1 parent 4c3593e
commit fb11d83
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/lib/stripe/api_resource.rb b/lib/stripe/api_resource.rb
@@ -98,7 +98,14 @@ def refresh
               "It is not possible to refresh v2 objects. Please retrieve the object using the StripeClient instead."
       end
 
-      @requestor.execute_request_initialize_from(:get, resource_url, :api, self, params: @retrieve_params)
+      @obj = @requestor.execute_request_initialize_from(:get, resource_url, :api, self, params: @retrieve_params)
+      initialize_from(
+        @obj.last_response.data,
+        @obj.instance_variable_get(:@opts),
+        @obj.last_response,
+        api_mode: :v1,
+        requestor: @requestor
+      )
     end
 
     def self.retrieve(id, opts = {})

diff --git a/test/stripe/api_resource_test.rb b/test/stripe/api_resource_test.rb
@@ -931,7 +931,7 @@ def self.resource_url
           .to_return(body: JSON.generate({ id: "id", object: "custom_stripe_object", result: "hello" }))
 
         custom_stripe_object = CustomStripeObject.retrieve("id")
-        assert_instance_of Stripe::StripeObject, custom_stripe_object
+        assert_instance_of CustomStripeObject, custom_stripe_object
         assert_equal "hello", custom_stripe_object.result
       end
     end