Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make lastPaymentError and lastSetupError consistent across platforms #990

Merged
merged 1 commit into from
Jun 15, 2022
Merged

fix: make lastPaymentError and lastSetupError consistent across platforms #990

merged 1 commit into from
Jun 15, 2022

Conversation

charliecruzan-stripe
Copy link
Collaborator

Summary

added declineCode to object on android, and used the message instead of description on iOS for the message field.

Testing

  • I tested this manually
  • I added automated tests

Documentation

Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

@charliecruzan-stripe charliecruzan-stripe marked this pull request as ready for review June 14, 2022 17:27
@charliecruzan-stripe charliecruzan-stripe merged commit 2281f7f into master Jun 15, 2022
@charliecruzan-stripe charliecruzan-stripe deleted the charliecruzan-fixlastsetuperror branch June 15, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acomley-stripe acomley-stripe Awaiting requested review from acomley-stripe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@charliecruzan-stripe