fix: resolve with Error.Canceled if no payment option is selected in Payment Sheet custom flow #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Payment Sheet custom flow
charliecruzan-stripe
deleted the
charliecruzan-custompaymentsheet-cancelled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
previously we'd return with a null error, and a null payment option is the flow was cancelled. this isn't necessarily bad, but it doesn't match the behavior of the non-custom flow, or any of our other flows.
Now, we resolve with an error.code == Canceled
Motivation
closes #723
Testing
Documentation
Select one: