fix: create custom babel plugin for package.json imports in src/
#902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliecruzan-stripe
deleted the
charliecruzan-babel-plugin-for-pjson-import
branch
|
Thx bae ❤️ |
|
Thx baes ❤️ |
| ImportDeclaration(path) { | ||
| let importResource = path.node.source.value ?? ''; | ||
| if (importResource.includes('../package.json')) { | ||
| importResource = '../' + importResource; |
There was a problem hiding this comment.
hm actually i think this isn't assign the new path to the actual path.node.source.value, will commit another fix
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
babel plugin identifies import declarations that need to be modified for transpilation. right now, that's only the
../../package.jsonimportMotivation
fixes #841
Testing
run
yarn preparewith these changes, andlib/commonjs/components/StripeProvider.jsandlib/module/components/StripeProvider.jshave the correct file path