fix: properly configure cursorColor for CardField on Android #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliecruzan-stripe
requested review from
michelleb-stripe
and removed request for
acomley-stripe
michelleb-stripe
approved these changes
Feb 11, 2022
charliecruzan-stripe
deleted the
charliecruzan/cursor-color-cardfield
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
cursorColorwasn't being assigned on Android.setTintwas added in Android 10 to programmatically change this color without relying on any XML, so let's use that.On android, there's a bit more granularity, but to match iOS I think we should apply cursorColor to the highlight and the textSelectHandles.
android:
ios:
Motivation
fixes #766, parity with iOS
Testing
Documentation
Select one: