Attribute any Expo-apps via setAppInfo

[cruzach]

An app is Expo managed workflow if they're using our fork of react-native (something like https://github.com/expo/react-native/archive/sdk-40.0.1.tar.gz), and an app is bare workflow if they do not use our fork, but do have the expo dependency (there are some in the bare workflow without that dependency, so this is 100% accurate, but it should capture the vast majority of folks).

I read up on Stripe's docs and wasn't sure if we should also include Expo's partnerId- for the time being I did, but let me know if I should remove that

[thorsten-stripe]

Doesn't pjson import the libraries package.json (https://github.com/stripe/stripe-react-native/blob/master/package.json) file? But for expo we'd need the project's package json, no? Would that just be two more folders above '../../../../package.json'; as the library is in the node_modules/stripe-react-native folder?

[thorsten-stripe]

Hm, those relative paths won't work. Any idea how we can get the projetc's root package.json?

[cruzach]

there doesn't seem to be a well-supported way of getting the root project's directory or package.json, but it might be simpler to instead just use the new optional imports feature from metro:

• if we can require('expo'), 👍
• otherwise, 👎

see most recent commit

[arekkubaczkowski]

sounds good, thanks!

[thorsten-stripe]

Hm, I've tested this on the example and even though expo is an installed dependency there, it didn't work, so I logged out the error from the require statement, and it's:

 [Error: Requiring unknown module "undefined". If you are sure the module exists, try restarting Metro. You may also want to run `yarn` or `npm install`.]

But I don't know why

[arekkubaczkowski]

true.. I think it will not work this way since expo in this case is in the example dependency tree (/example/node_modeules/) I will try to figure out other solution

[arekkubaczkowski]

but in a real project it should be placed at the same level - I will try it and let you know.

[arekkubaczkowski]

yes it works but for some reason it throws an error if expo is not installed - try catch doesn't work, but should be there some workaround for this

[thorsten-stripe]

@arekkubaczkowski do you not get the above error, even if expo is installed? I did some Googling, and supposedly this error happens if you import dependencies twice: facebook/metro#152 (comment) But not sure if that is the issue in our case.

[arekkubaczkowski]

I think it's due to improper version of stripe-react-native sdk installed - https://github.com/cruzach/optional-imports/blob/main/.yalc/stripe-react-native/src/helpers.ts, there is no require('expo')

[cruzach]

I don't think it's using the .yalc version- confirmed by removing the .yalc/ directory and rerunning, plus I'm still seeing the console.logs from node_modules/stripe-react-native/src/helpers.ts:

try {
  require('expo');
  console.log('yes')
} catch {
  console.log('no')
  isExpoInstalled = false;
}

results in:

[Tue Mar 30 2021 10:13:05.531]  LOG      no

[cruzach]

maybe an issue with yalc?

[cruzach]

@arekkubaczkowski let me know if there's anything else I can do here 🙂

[arekkubaczkowski]

@cruzach I've run your project and it works properly so probably smth was wrong with my local project. I think that we can merge it

[thorsten-stripe]

@arekkubaczkowski also, we need to change the appinfo approach: instead of pulling it from the package.json, we should hardcode it. E.g. if someone forks the repo, we still want the same appinfo to be sent

[thorsten-stripe]

@arekkubaczkowski also, we need to change the appinfo approach: instead of pulling it from the package.json, we should hardcode it. E.g. if someone forks the repo, we still want the same appinfo to be sent

@arekkubaczkowski actually, scratch that, it's good for us to know if someone has forked it. So let's keep withe the current approach 👍

[arekkubaczkowski]

@thorsten-stripe works both in example and external projects for me.