Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not publish unnecessary files #1043

Merged
merged 2 commits into from
Jul 14, 2022

Conversation

charliecruzan-stripe
Copy link
Collaborator

@charliecruzan-stripe charliecruzan-stripe commented Jul 14, 2022

Summary

we were including files that didn't need to be included bc package.json's files totally overrides .npmignore. So even though we were ignoring subdirectories, it didn't matter.

Removed files usage altogether, all appropriate file handling is in .npmignore now

Motivation

Reduces the size of our distributed package

Testing

  • I tested this manually
  • I added automated tests

used npm pack and diff'd the before and after to ensure that only the expected files were deleted

Documentation

Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

@charliecruzan-stripe charliecruzan-stripe removed the request for review from acomley-stripe July 14, 2022 18:16
@charliecruzan-stripe charliecruzan-stripe merged commit 5a6154d into master Jul 14, 2022
@charliecruzan-stripe charliecruzan-stripe deleted the charliecruzan-npmignore-updates branch July 14, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant