Discrepancy between Date handling on iOS and Android #368
Comments
jonasbark
added a commit
to flutter-stripe/flutter_stripe
that referenced
this issue
Jun 23, 2021
remonh87
pushed a commit
to flutter-stripe/flutter_stripe
that referenced
this issue
Jun 27, 2021
jonasbark
added a commit
to flutter-stripe/flutter_stripe
that referenced
this issue
Jul 4, 2021
* sync android code * implement new parsing cardfield and paymentintent * comply to new result propagation for setupintent * sync ios * Update dart layer * Throw errors for easy debug + cancel login when error * workaround for stripe/stripe-react-native#368, also adjusted canceledAt * migrate to flutter_lints because pedantic is deprecated * implement create token method (#165) * implement create token method * add create token to example app * Add createToken for iOS * Make example tiles scrollable Co-authored-by: Jaime Blasco <[email protected]> * improve documentation for Android and issues #155 #142 * fix merge issue * add urlscheme to initialise method * BREAKING: rename threedsecure button config and add config theme for other buttons * BREAKING make paymentIntentClientSecret nullable and add setupIntentClientSecret for paymentsheet * add fontfamily and dangerouslyGetFullCardDetails to cardfield Co-authored-by: Remon <[email protected]> Co-authored-by: Remon Helmond <[email protected]> Co-authored-by: Jaime Blasco <[email protected]>
softdev55
added a commit
to softdev55/flutter_stripe
that referenced
this issue
Aug 30, 2022
* sync android code * implement new parsing cardfield and paymentintent * comply to new result propagation for setupintent * sync ios * Update dart layer * Throw errors for easy debug + cancel login when error * workaround for stripe/stripe-react-native#368, also adjusted canceledAt * migrate to flutter_lints because pedantic is deprecated * implement create token method (#165) * implement create token method * add create token to example app * Add createToken for iOS * Make example tiles scrollable Co-authored-by: Jaime Blasco <[email protected]> * improve documentation for Android and issues #155 #142 * fix merge issue * add urlscheme to initialise method * BREAKING: rename threedsecure button config and add config theme for other buttons * BREAKING make paymentIntentClientSecret nullable and add setupIntentClientSecret for paymentsheet * add fontfamily and dangerouslyGetFullCardDetails to cardfield Co-authored-by: Remon <[email protected]> Co-authored-by: Remon Helmond <[email protected]> Co-authored-by: Jaime Blasco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We noticed a discrepancy between iOS / Android regarding "created" attribute on PaymentIntent on the native side:
https://github.com/stripe/stripe-react-native/blob/master/android/src/main/java/com/reactnativestripesdk/Mappers.kt#L328 -> created is a string
https://github.com/stripe/stripe-react-native/blob/master/ios/Mappers.swift#L360 -> created is an int
https://github.com/stripe/stripe-react-native/blob/master/src/types/PaymentIntents.ts#L7 -> created is a string
I'm not sure if it has an effect on React Native itself but it does on Android. Adjusting convertToUnitTimestamp on Mappers.kt on Android to return a String would fix this issue.
The text was updated successfully, but these errors were encountered: