Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features missing from tipsi-stripe #196

Closed
tgensol opened this issue May 10, 2021 · 14 comments
Closed

Features missing from tipsi-stripe #196

tgensol opened this issue May 10, 2021 · 14 comments
Labels
question Further information is requested

Comments

@tgensol
Copy link
Collaborator

tgensol commented May 10, 2021

Hi there,

I am trying to move from tipsi-stripe and I am "missing" some features :

CardField focusing

  • An AutoFocus/focus function on the CardField component could be really cool. It will save some clicks to my user and by abtesting we saw that the conversion rate was better in the past
  • Separated card number, cvc and expiration. We saw by doing abtesting, that your "credit card" component is not always understood, and we really liked to be able to have every inputs separated. Is it something possible ? (like this)

ApplePay hiding

  • It was possible to "hide" the apple Pay modal if an error was happening. We can only presentApplePay
  • isApplePaySupported means that Apple Pay is enabled and a credit card is ready ? I used to have deviceSupportsNativePay and canMakeNativePayPayments

Google Pay

  • I used to have deviceSupportsNativePay and canMakeNativePayPayments, but now I cannot know if the user can pay with Google Pay now
  • Android Pay native, without having to use your UI sheet

Really thanks a lot for this first version ! It works very well on my side for my first tests (but it is not yet on production where we have 100k transactions per month)

Thanks a lot for your time

@aakanksha-02
Copy link

Hey, is your Apple Pay implementation woking with this?

@tgensol
Copy link
Collaborator Author

tgensol commented May 11, 2021

Hey, yes ! I followed the example and not the doc

@aakanksha-02
Copy link

Hey, yes ! I followed the example and not the doc

https://github.com/stripe/stripe-react-native/blob/master/example/src/screens/ApplePayScreen.tsx You mean this example ?

@thorsten-stripe
Copy link
Contributor

An AutoFocus/focus function on the CardField component could be really cool. It will save some clicks to my user and by abtesting we saw that the conversion rate was better in the past

Would you mind opening a feature request for that?

Separated card number, cvc and expiration. We saw by doing abtesting, that your "credit card" component is not always understood, and we really liked to be able to have every inputs separated. Is it something possible ? (like this)

We're tracking this feature here: #83

It was possible to "hide" the apple Pay modal if an error was happening. We can only presentApplePay

This is being tracked here: #148 (comment)

isApplePaySupported means that Apple Pay is enabled and a credit card is ready ? I used to have deviceSupportsNativePay and canMakeNativePayPayments

Correct: "YES if the device is currently able to make Apple Pay payments via one of the supported networks. NO if the user does not have a saved card of a supported type, or other restrictions prevent payment (such as parental controls)." - https://stripe.dev/stripe-ios/docs/Classes/StripeAPI.html#/c:@M@Stripe@objc(cs)StripeAPI(cm)deviceSupportsApplePay

I used to have deviceSupportsNativePay and canMakeNativePayPayments, but now I cannot know if the user can pay with Google Pay now

Standalone Google Pay is not yet supported (tracked here: #9). Google Pay is currently only supported via the payment sheet integration: https://stripe.com/docs/payments/accept-a-payment?platform=react-native&ui=payment-sheet#google-pay

Android Pay native, without having to use your UI sheet

Would you mind outlining why you can't (or don't want to) use the payment sheet? It would give you the split fields that you desire as well as Google Pay support. Would love for you to evaluate this option and provide feedback!

For all the folks that added a 👍 , could you outline which ask(s) your 👍 relates to? That would help us a lot, thanks 🙏

@thorsten-stripe thorsten-stripe added the question Further information is requested label May 11, 2021
@thorsten-stripe
Copy link
Contributor

@tgensol did you have a chance to evaluate if the new payment sheet could fit your needs? And if not, can you outline why/what you're missing? Thanks.

@tgensol
Copy link
Collaborator Author

tgensol commented May 14, 2021

Hi @thorsten-stripe ,

Not yet, I plan to do it today :) ! But the perfect flow for me is to have a separated button like Apple Pay, that open the Google Pay modal sheet

@Yonom
Copy link
Collaborator

Yonom commented May 19, 2021

@thorsten-stripe We would also love to migrate to this library from tipsi-stripe

However, the lack of direct Google Pay support is also a blocker for my team.

We already have a payments sheet and we like the way it looks (size and placement of product logos, look and feel, colors, fonts, etc.), we would also like to retain the ability to iterate on our design and layout. Our app also supports local payment methods which are seemingly not supported in the payments sheet.

We're using stripe for the functionality it provides, so please give us the choice to implement our UI the way we want 🙂

@thorsten-stripe
Copy link
Contributor

@Yonom thank you for the feedback! As mentioned, standalone Google Pay support is being tracked here: #9

I'm going to close this issue out as I believe all mentioned asks are being traced in their own issues: #196 (comment)

Please let me know if that isn't the case, thanks.

@DanGDroid
Copy link
Collaborator

CardField focusing
An AutoFocus/focus function on the CardField component could be really cool. It will save some clicks to my user and by abtesting we saw that the conversion rate was better in the past

we actually preffer not to force Auto focuse (it can be good to set as an optional param),
because we have another InputText - Card Holder - before the Card Input
Screenshot 2021-05-24 at 13 43 49

@thorsten-stripe
Copy link
Contributor

@DanGDroid autofocus is false by default, so it only focuses if you set autofocus to true.

@anija
Copy link

anija commented May 25, 2021

tipsi-stripe allowed to get the Apple Payment token using paymentRequestWithNativePay (https://tipsi.github.io/tipsi-stripe/docs/paymentRequestWithNativePay.html).
Any chance to get the same feature?

@thorsten-stripe
Copy link
Contributor

@anija this is being tracked here: #271

@anija
Copy link

anija commented May 27, 2021

@anija this is being tracked here: #271

thank you!

@khenriksson
Copy link

Is there any way to check whether cards have been added for Google Pay? I suppose initGooglePay only checks whether it's possible to use Google Pay on the device, not whether it's configured? What I'm basically looking for is something resembling canMakeNativePayPayments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

7 participants