Fix quality issues reported by DeepSource

[sauravsrijan]

Fixes:

• PYL-W0612: Rename unused variable to _
• PYL-C0123: Use isinstance() for checking type
• PAP-W0011: Use dict.items() to iterate over a dictionary
• PAP-W0012: Use dict.get() to access value from dictionary instead of an if query to check whether the key exists
• PYL-C0325: Remove superfluous brackets ()
• PYL-R1701: Merge multiple consecutive isinstance() calls into one

[sauravsrijan]

Hi @ob-stripe, here are some more code quality issues fixed.
I would also suggest you to update the .deepsource.toml config file to make the analysis better and ignore issues which might not be important for you.

Suggestions:

• In the config, add tests/** in test-patterns to ignore running analysis on test files.
• Set max-line-length to 100 in the toml. You would need to add an [analyzers.meta] field and set it inside it. You can see an example here.

[ob-stripe]

One minor request, but looks great! Thanks!

[sauravsrijan]

Updated the PR. Good to go.

[ob-stripe]

Awesome, thanks!

[ob-stripe]

Released as 2.28.2.

[ob-stripe]

In the config, add tests/** in test-patterns to ignore running analysis on test files.

@sauravsrijan I've already added tests/* per the example in https://deepsource.io/docs/configuration/analysis.html#test-patterns. Do I need ** so that it applies to all subdirectories as well?

[sauravsrijan]

You have to do tests/** to discover files recursively.
tests/* will only match one level.