Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe @remi-stripe
cc @stripe/api-libraries
A bunch of improvements and fixes to the
Collection
model:requestParams
tofilters
, which conveys the intent better and is consistent with stripe-ruby (this is a breaking change, though I don't think many users use this)offsetGet
(magic method invoked when accessing elements via[]
) to output a helpful error message when using numeric indices (this is consistent with stripe-ruby)emptyCollection()
static constructor, andnextPage()
andpreviousPage()
helper methods. SimplifyautoPagingIterator()
by usingnextPage()
(again, this is consistent with stripe-ruby)all
/create
/retrieve
method. Previously they updated the filters on the instance, which was incorrect. Nowall
correctly sets the filters on the returned object (not the object on which the method is called), andcreate
andretrieve
don't set the filters.all
/create
/retrieve
and the methods inCollection
, but unfortunately PHP does not have anything like Ruby'sinclude
vs.extend
to add trait methods as static methods or instance methods.