Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Balance History endpoint to /v1/balance_transactions #683

Merged
merged 1 commit into from
Aug 1, 2019
Merged

Move Balance History endpoint to /v1/balance_transactions #683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,7 @@ matrix:

env:
global:
- STRIPE_MOCK_VERSION=0.60.0

- STRIPE_MOCK_VERSION=0.63.0
cache:
directories:
- $HOME/.composer/cache/files
Expand Down
9 changes: 0 additions & 9 deletions lib/BalanceTransaction.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,4 @@ class BalanceTransaction extends ApiResource
const TYPE_TRANSFER_CANCEL = 'transfer_cancel';
const TYPE_TRANSFER_FAILURE = 'transfer_failure';
const TYPE_TRANSFER_REFUND = 'transfer_refund';

/**
* @return string The class URL for this resource. It needs to be special
* cased because it doesn't fit into the standard resource pattern.
*/
public static function classUrl()
{
return "/v1/balance/history";
}
}
4 changes: 2 additions & 2 deletions tests/Stripe/BalanceTransactionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ public function testIsListable()
{
$this->expectsRequest(
'get',
'/v1/balance/history'
'/v1/balance_transactions'
);
$resources = BalanceTransaction::all();
$this->assertTrue(is_array($resources->data));
Expand All @@ -21,7 +21,7 @@ public function testIsRetrievable()
{
$this->expectsRequest(
'get',
'/v1/balance/history/' . self::TEST_RESOURCE_ID
'/v1/balance_transactions/' . self::TEST_RESOURCE_ID
);
$resource = BalanceTransaction::retrieve(self::TEST_RESOURCE_ID);
$this->assertInstanceOf("Stripe\\BalanceTransaction", $resource);
Expand Down
2 changes: 1 addition & 1 deletion tests/bootstrap.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

require_once(__DIR__ . '/StripeMock.php');

define("MOCK_MINIMUM_VERSION", "0.60.0");
define("MOCK_MINIMUM_VERSION", "0.63.0");

if (\Stripe\StripeMock::start()) {
register_shutdown_function('\Stripe\StripeMock::stop');
Expand Down