Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated phpdocs #468

Merged
merged 1 commit into from
May 14, 2018
Merged

Updated phpdocs #468

merged 1 commit into from
May 14, 2018

Conversation

nickdnk
Copy link
Contributor

@nickdnk nickdnk commented May 12, 2018

Hey guys

I made some updates to phpdocs for missing/new properties :)

Cheers

* @property string $name
* @property string $rolled_back_from
* @property string $type
* @property bool $verified
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should pull verified? I think it's technically supposed to be undocumented.

@brandur-stripe
Copy link
Contributor

Excellent work as usual @nickdnk! Thanks so much for the corrections.

I left one minor comment above, but this looks good to me.

@nickdnk
Copy link
Contributor Author

nickdnk commented May 13, 2018

@brandur-stripe I've removed the verified property as requested and also added $support_address to Account and changed $external_accounts to Collection instead of mixed.

@brandur-stripe
Copy link
Contributor

@nickdnk Excellent. Thank you!

@brandur-stripe brandur-stripe merged commit b03f03f into stripe:master May 14, 2018
@brandur-stripe
Copy link
Contributor

Released as 6.7.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants