Added PHPDocs for create, update, delete, all, retrieve methods after moving them out of traits.
#1701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anniel-stripe
approved these changes
May 28, 2024
|
Are we not planning to delete the files that define the different traits that we are now not using? |
|
And are we not planning to remove the update method from the Update trait? |
|
We can't remove the traits as there is a concern with these overrides that still use the traits. I'll have to look into these and change some behavior(or the override itself). |
prathmesh-stripe
force-pushed
the
prathmesh_php_demagicing_crudl
branch
from
cd30bb2
to
bb8f2b1
Compare
ramya-stripe
changed the title
ramya-stripe
changed the title
create, update, delete, all, retrieve methods after moving them out of traits.
anniel-stripe
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved
Create,Update,Delete,All,Retrievetraits to resources.