Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Run phpstan job with PHP 8.1 only #1380

Merged
merged 2 commits into from
Jan 19, 2023
Merged

Fix: Run phpstan job with PHP 8.1 only #1380

merged 2 commits into from
Jan 19, 2023

Conversation

localheinz
Copy link
Contributor

This pull request

  • runs the phpstan job with PHP 8.1 only

💁‍♂️ I doubt that phpstan/phpstan will find different issues on different versions of PHP.

@localheinz
Copy link
Contributor Author

@richardm-stripe

Really, does every push need approval from a maintainer?

@szepeviktor
Copy link
Contributor

I doubt that phpstan/phpstan will find different issues on different versions of PHP.

This can be ultimately resolved by adding PHP version to PHPStan configuration file.
e.g. phpVersion: 70400

@pakrym-stripe pakrym-stripe merged commit ac3bf4d into stripe:master Jan 19, 2023
@pakrym-stripe
Copy link
Contributor

Thank you for your contribution, @localheinz. Sorry for the delay.

@localheinz
Copy link
Contributor Author

Thank you, @pakrym-stripe!

@localheinz localheinz deleted the fix/phpstan branch January 19, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@localheinz @szepeviktor @pakrym-stripe