Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error codes #1329

Merged
merged 1 commit into from
Jul 22, 2022
Merged

Conversation

yejia-stripe
Copy link
Contributor

r? @dcr-stripe

Summary

Update error codes based on https://stripe.com/docs/error-codes.

Changelog

  • ⚠️ Remove deprecated error codes:
    • 'account_already_exists'
    • 'order_creation_failed'
    • 'order_required_settings'
    • 'order_status_invalid'
    • 'order_upstream_timeout'
    • 'upstream_order_creation_failed'
  • Add error codes:
    • 'account_error_country_change_requires_additional_steps'
    • 'account_information_mismatch'
    • 'acss_debit_session_incomplete'
    • 'authentication_required'
    • 'bank_account_bad_routing_numbers'
    • 'bank_account_declined'
    • 'bank_account_verification_failed'
    • 'billing_invalid_mandate'
    • 'card_decline_rate_limit_exceeded'
    • 'cardholder_phone_number_required'
    • 'charge_invalid_parameter'
    • 'clearing_code_unsupported'
    • 'country_code_invalid'
    • 'customer_max_payment_methods'
    • 'debit_not_authorized'
    • 'instant_payouts_limit_exceeded'
    • 'insufficient_funds'
    • 'intent_invalid_state'
    • 'intent_verification_method_missing'
    • 'invalid_characters'
    • 'invoice_no_payment_method_types'
    • 'invoice_on_behalf_of_not_editable'
    • 'no_account'
    • 'payment_intent_action_required'
    • 'payment_intent_konbini_rejected_confirmation_number'
    • 'payment_intent_mandate_invalid'
    • 'payment_intent_payment_attempt_expired'
    • 'payment_method_bank_account_already_verified'
    • 'payment_method_bank_account_blocked'
    • 'payment_method_billing_details_address_missing'
    • 'payment_method_currency_mismatch'
    • 'payment_method_invalid_parameter'
    • 'payment_method_invalid_parameter_testmode'
    • 'payment_method_microdeposit_failed'
    • 'payment_method_microdeposit_verification_amounts_invalid'
    • 'payment_method_microdeposit_verification_amounts_mismatch'
    • 'payment_method_microdeposit_verification_attempts_exceeded'
    • 'payment_method_microdeposit_verification_descriptor_code_mismatch'
    • 'payment_method_microdeposit_verification_timeout'
    • 'payment_method_provider_decline'
    • 'payment_method_provider_timeout'
    • 'payment_method_unsupported_type'
    • 'platform_account_required'
    • 'refer_to_customer'
    • 'refund_disputed_payment'
    • 'return_intent_already_processed'
    • 'setup_intent_invalid_parameter'
    • 'setup_intent_setup_attempt_expired'
    • 'terminal_location_country_unsupported'
    • 'transfer_source_balance_parameters_mismatch'

Copy link
Contributor

@dcr-stripe dcr-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Yejia!

@stripe-ci stripe-ci assigned yejia-stripe and unassigned dcr-stripe Jul 22, 2022
@yejia-stripe yejia-stripe merged commit 7a1d32b into sdk-release/next-major Jul 22, 2022
@yejia-stripe yejia-stripe deleted the yejia/clean-up-errors branch July 22, 2022 14:58
dcr-stripe added a commit that referenced this pull request Aug 1, 2022
* chore!: Update CA certifacte bundle (Apr 26). (#1314)

* Update error codes (#1329)

r? @dcr-stripe 

## Summary
Update error codes based on https://stripe.com/docs/error-codes.

## Changelog
- ⚠️ Remove deprecated error codes:
  - `'account_already_exists'`
  - `'order_creation_failed'`
  - `'order_required_settings'`
  - `'order_status_invalid'`
  - `'order_upstream_timeout'`
  - `'upstream_order_creation_failed'`
- Add error codes:
  - `'account_error_country_change_requires_additional_steps'`
  - `'account_information_mismatch'`
  - `'acss_debit_session_incomplete'`
  - `'authentication_required'`
  - `'bank_account_bad_routing_numbers'`
  - `'bank_account_declined'`
  - `'bank_account_verification_failed'`
  - `'billing_invalid_mandate'`
  - `'card_decline_rate_limit_exceeded'`
  - `'cardholder_phone_number_required'`
  - `'charge_invalid_parameter'`
  - `'clearing_code_unsupported'`
  - `'country_code_invalid'`
  - `'customer_max_payment_methods'`
  - `'debit_not_authorized'`
  - `'instant_payouts_limit_exceeded'`
  - `'insufficient_funds'`
  - `'intent_invalid_state'`
  - `'intent_verification_method_missing'`
  - `'invalid_characters'`
  - `'invoice_no_payment_method_types'`
  - `'invoice_on_behalf_of_not_editable'`
  - `'no_account'`
  - `'payment_intent_action_required'`
  - `'payment_intent_konbini_rejected_confirmation_number'`
  - `'payment_intent_mandate_invalid'`
  - `'payment_intent_payment_attempt_expired'`
  - `'payment_method_bank_account_already_verified'`
  - `'payment_method_bank_account_blocked'`
  - `'payment_method_billing_details_address_missing'`
  - `'payment_method_currency_mismatch'`
  - `'payment_method_invalid_parameter'`
  - `'payment_method_invalid_parameter_testmode'`
  - `'payment_method_microdeposit_failed'`
  - `'payment_method_microdeposit_verification_amounts_invalid'`
  - `'payment_method_microdeposit_verification_amounts_mismatch'`
  - `'payment_method_microdeposit_verification_attempts_exceeded'`
  - `'payment_method_microdeposit_verification_descriptor_code_mismatch'`
  - `'payment_method_microdeposit_verification_timeout'`
  - `'payment_method_provider_decline'`
  - `'payment_method_provider_timeout'`
  - `'payment_method_unsupported_type'`
  - `'platform_account_required'`
  - `'refer_to_customer'`
  - `'refund_disputed_payment'`
  - `'return_intent_already_processed'`
  - `'setup_intent_invalid_parameter'`
  - `'setup_intent_setup_attempt_expired'`
  - `'terminal_location_country_unsupported'`
  - `'transfer_source_balance_parameters_mismatch'`

* Generate stripe-php with breaking changes

* Remove more resources

* Remove tests to removed resources

* Regenerate files

* Remove outdated test

* Remove outdated test

* Fix more tests

* Fix type

* Remove outdated test

* Fix syntax

* Change return type in a test

* Change allSourcesTest to expect a StripeObject for now.

* Fix SourceTest

* Remove unused OrderItem class. (#1342)

Co-authored-by: Dominic Charley-Roy <[email protected]>
Co-authored-by: yejia-stripe <[email protected]>
Co-authored-by: Dominic Charley-Roy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants