Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Run friendsofphp/php-cs-fixer as installed with composer #1292

Closed
wants to merge 1 commit into from
Closed

Fix: Run friendsofphp/php-cs-fixer as installed with composer #1292

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,29 @@ jobs:
steps:
- uses: actions/checkout@master

- name: PHP-CS-Fixer
uses: docker://oskarstark/php-cs-fixer-ga:3.4.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compare with composer.json:

stripe-php/composer.json

Line 26 in 47cfc40

"friendsofphp/php-cs-fixer": "3.5.0",

- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
args: --format=txt --diff --dry-run --using-cache=no --verbose .
php-version: ${{ matrix.php-version }}

- name: Get Composer Cache Directory
id: composer-cache
run: |
echo "::set-output name=dir::$(composer config cache-files-dir)"

- uses: actions/cache@v2
with:
path: ${{ steps.composer-cache.outputs.dir }}
key: ${{ runner.os }}-composer-${{ hashFiles('composer.json') }}

- name: Validate composer.json and composer.lock
run: composer validate

- name: Install dependencies
run: composer install --prefer-dist --no-progress

- name: PHP-CS-Fixer
run: vendor/bin/php-cs-fixer fix --format=txt --diff --dry-run --using-cache=no --verbose .

phpstan:
name: PHPStan
Expand Down