-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Configure finder for friendsofphp/php-cs-fixer
#1291
Conversation
This PR may need #1292 as the dot is removed. |
756d53d
to
e902180
Compare
Looks like the workflow needs an approval, can you do that, please? |
Coveralls said Couldn't find a repository matching this job |
See https://github.com/stripe/stripe-php/actions/runs/3267022039/jobs/5371671598#step:11:8, as well as stripe-php/.github/workflows/ci.yml Line 144 in 13e8ab3
The |
I'm going to ignore coveralls and debug that separately. This PR shouldn't affect test coverage. |
Thank you for the contribution @localheinz! |
Thank you, @richardm-stripe! I do not know whether coveralls supports token-less upload of code-coverage reports. I do know that token-less upload works well with https://codecov.io. Similar to https://github.com/coverallsapp/github-action, codecov offers an action for uploading code coverage reports, see https://github.com/codecov/codecov-action. |
This pull request
friendsofphp/php-cs-fixer
Running
on current
master
yields