Add some PHPDoc return types and fixes #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szepeviktor
reviewed
May 22, 2022
franmomu
force-pushed
the
more_void
branch
2 times, most recently
from
f5888b9
to
23f935c
Compare
franmomu
force-pushed
the
more_void
branch
2 times, most recently
from
4fc2f80
to
c7342fd
Compare
|
@pakrym-stripe Could you help starting up CI? |
pscheit
approved these changes
Jul 19, 2022
|
@franmomu thanks for that, can you check the conflicts? |
|
now we just need someone to push the CI :) @pakrym-stripe maybe? :) |
|
Thank you, friends! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind of follow-up of #1230
It also fixes some PHPDoc (found by PHPStan raising the current level)
r? @pakrym-stripe