Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for updating the version of the repo #1262

Merged
merged 2 commits into from
Apr 13, 2022

Conversation

pakrym-stripe
Copy link
Contributor

Encodes the logic for version updating as a Makefile. Simplifies what the generation tools needs to know about the repo.
The plan is to have the same interface across all the repos.

Sample usage:

make update-version VERSION=1.2.5

Also adds a target that codegen will use to format all our repos:

make codegen-format

Copy link
Contributor

@richardm-stripe richardm-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unintended deletes?

@pakrym-stripe
Copy link
Contributor Author

unintended deletes?

Yep, fixed.

@pakrym-stripe
Copy link
Contributor Author

re-r? @richardm-stripe

@pakrym-stripe pakrym-stripe merged commit 8134e54 into master Apr 13, 2022
@remi-stripe remi-stripe deleted the pakrym/Add_a_common_Makefile branch July 25, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants