Improve readme for old PHP versions #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardm-stripe
approved these changes
Jul 12, 2021
lode
reviewed
Jul 17, 2021
| @@ -76,11 +76,13 @@ See [video demonstrations][youtube-playlist] covering how to use the library. | |||
|
|
|||
| ### PHP 5.4 & 5.5 | |||
|
|
|||
| If you are using PHP 5.4 or 5.5, you can download v6.21.1 ([zip](https://github.com/stripe/stripe-php/archive/v6.21.1.zip), [tar.gz](https://github.com/stripe/stripe-php/archive/v6.21.1.tar.gz)) from our [releases page](https://github.com/stripe/stripe-php/releases). This version will continue to work with new versions of the Stripe API for all common uses. | |||
| If you are using PHP 5.4 or 5.5, you should consider upgrading your environment as those versions have been past end of life since September 2015 and July 2016 respectively. | |||
| Otherwise, you can still use Stripe by downloading stripe-php v6.43.1 ([zip](https://github.com/stripe/stripe-php/archive/v6.43.1.zip), [tar.gz](https://github.com/stripe/stripe-php/archive/v6.21.1.tar.gz)) from our [releases page](https://github.com/stripe/stripe-php/releases). This version will work but might not support recent features we added since the version was released and upgrading PHP is the best course of action. | |||
There was a problem hiding this comment.
I don't know if the change from 6.21.1 to 6.43.1 was intentional, but at least the zip and tar.gz links now point to different releases.
There was a problem hiding this comment.
@lode it was intentional. We didn't drop support for old PHP version until the next major, so the link points to the most recent minor version for 6.x with support for those PHP versions.
There was a problem hiding this comment.
ah damn I see what you meant, I only fixed one, sorry. Nice catch. Let me amend quickly in another PR
There was a problem hiding this comment.
Okay fixed in #1161
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update readme to make it clearer how to use (or not use) old PHP versions.
r? @richardm-stripe
cc @stripe/api-libraries