Improve error message for invalid keys in StripeClient

stripe · Nov 30, 2020 · 8aadf5d · 8aadf5d
1 parent 0dc50f4
commit 8aadf5d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/lib/BaseStripeClient.php b/lib/BaseStripeClient.php
@@ -260,7 +260,9 @@ private function validateConfig($config)
         // check absence of extra keys
         $extraConfigKeys = \array_diff(\array_keys($config), \array_keys($this->getDefaultConfig()));
         if (!empty($extraConfigKeys)) {
-            throw new \Stripe\Exception\InvalidArgumentException('Found unknown key(s) in configuration array: ' . \implode(',', $extraConfigKeys));
+            // Wrap in single quote to more easily catch trailing spaces errors
+            $invalidKeys = "'" . \implode("', '", $extraConfigKeys) . "'";
+            throw new \Stripe\Exception\InvalidArgumentException('Found unknown key(s) in configuration array: ' . $invalidKeys);
         }
     }
 }
diff --git a/tests/Stripe/BaseStripeClientTest.php b/tests/Stripe/BaseStripeClientTest.php
@@ -60,9 +60,9 @@ public function testCtorThrowsIfApiKeyIsUnexpectedType()
     public function testCtorThrowsIfConfigArrayContainsUnexpectedKey()
     {
         $this->expectException(\Stripe\Exception\InvalidArgumentException::class);
-        $this->expectExceptionMessage('Found unknown key(s) in configuration array: foo');
+        $this->expectExceptionMessage('Found unknown key(s) in configuration array: \'foo\', \'foo2\'');
 
-        $client = new BaseStripeClient(['foo' => 'bar']);
+        $client = new BaseStripeClient(['foo' => 'bar', 'foo2' => 'bar2']);
     }
 
     public function testRequestWithClientApiKey()